Merged
Conversation
Remove broken Travis CI configuration (.travis.yml) Add GitHub Actions workflow for testing on ubuntu, macos, and windows Strictly test on Go 1.25.x to match the go.mod directive Include gofmt, go vet, and go install to ensure build integrity
wader
reviewed
Mar 26, 2026
| exit 1 | ||
| fi | ||
|
|
||
| - name: Run go vet (lint) |
Collaborator
There was a problem hiding this comment.
if: matrix.os == 'ubuntu-latest' also? or combine fmt and vet in one step?
wader
reviewed
Mar 26, 2026
Collaborator
wader
left a comment
wader
left a comment
There was a problem hiding this comment.
Looks good 👍 just one suggestion. I'll merge once you confirm
Contributor
Author
|
@wader, Great suggestion! I have combined the fmt and vet steps into a single Lint step and restricted it to run only on ubuntu-latest. Please review this and decide whether to merge it. |
Collaborator
|
Looks like it ran fine https://github.com/cortesi/devd/actions/runs/23621673191 🥳 |
Contributor
Author
|
Confirmed! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated the CI pipeline to use GitHub Actions, replacing the broken Travis CI and AppVeyor setups.
Changes
Technical Implementation Details
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true. This prepares the repository for the upcoming Node 20 EOL (April 2026) and ensures the CI remains functional and secure without deprecation warnings.workflow_dispatchto allow manual trigger of the CI from the Actions tab, providing better control for debugging or maintenance.gofmt: Ensures all contributions follow the standard Go style, reducing reviewer burden.go vet: Catch common logical errors at the CI stage.go run ./cmd/devd --helpto verify the final binary's execution integrity across all platforms.Note
I found that AppVeyor was likely configured via the Web UI rather than a .appveyor.yml file, as no such file existed in the root. Therefore, I could not "delete" its configuration via git. Once this PR is merged, the repository owner should manually disable the AppVeyor project in its admin dashboard to avoid redundant (and failing) builds.
The Run gofmt to fix formatting issues commit was added because the new GitHub Actions workflow now strictly enforces gofmt compliance—a check that was missing in the previous CI setup. This ensures the entire repository adheres to official Go standards moving forward.
Verification
I have verified this entire workflow on my fork, and all three OS environments (Ubuntu, macOS, Windows) passed the build and test suites successfully.
You can verify the successful CI runs here: https://github.com/chebread/devd/actions